Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken tests #416

Closed
allaway opened this issue Apr 4, 2024 · 1 comment · Fixed by #421
Closed

broken tests #416

allaway opened this issue Apr 4, 2024 · 1 comment · Fixed by #421
Assignees
@anngvu
Labels
bug Something isn't working

Comments

@allaway
Copy link
Contributor

allaway commented Apr 4, 2024 •
edited
Loading

I ran into the same issue with broken tests seen in #415 using the schematic CLI locally.

Thread here: https://sagebionetworks.slack.com/archives/C01ANC02U59/p1712190013230959

At least locally, pinning ipython==8.18.1 seemed to resolve this issue!
@allaway allaway added the bug Something isn't working label Apr 4, 2024
@allaway
Copy link
Contributor Author

allaway commented Apr 4, 2024 •
edited
Loading

Note - seems like they may be planning on fixing on the schematic side with short term and long term fixes: https://sagebionetworks.jira.com/browse/FDS-1925

This was referenced Apr 11, 2024
Merged
Closed
@anngvu anngvu linked a pull request Apr 11, 2024 that will close this issue
Patch tests, schematic update with 'typing_extensions' bug workaround, add bmp format #421
Merged
1 task
@anngvu anngvu moved this to Done in NF-OSI Sprints Apr 11, 2024
@anngvu anngvu closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anngvu anngvu

Labels
bug Something isn't working
Projects
NF-OSI Sprints
Status: Done
Milestone
No milestone
2 participants
@allaway @anngvu