-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monthly Data Model Release #539
Comments
@changtotheintothemoon Can you do the release for this month since Aditya did the last month's and just so everyone goes through the process at least once? |
|
@changtotheintothemoon The intention of the first item is to "check that templates can be generated so users don't complain about broken templates". Sometimes we can make a change in the data model and the template can't be generated or looks strange because of a bug. The easiest way is to confirm that templates OK is to look at the ones generated by the tests in a recent PR, e.g. your PR was merged pretty recently and shows successful tests #543. Or the old way was to go to the staging instance of the DCA (https://dca-staging.app.sagebionetworks.org/) and try generating templates through the UI. Again, this was sometimes done in the old days. But the first way is easier and faster, the second way is much more extensive and painful, but that's an option if you also want to do "UI testing". |
@changtotheintothemoon Hmm, maybe we should have another issue to update the checklist to have more details... 🤔 |
@anngvu |
@changtotheintothemoon Oh, don't worry about that -- that is not due to your changes (wouldn't have merged if it were). We just need to sign the new terms of use for the test account: |
But since you have reviewed and clarified the recent test results, go ahead and check off the first item! |
One is marked as draft, so I think you can ignore this one. I know the other is not urgent. In general, we can also ask at standup if any of the PRs are urgent and whether they can be merged quickly enough to get the release out. But I know these are not super important. |
New PR available for this to change version of the tag: |
Summary
This issue helps ensure that at least one data model release is created monthly.
Checklist
The text was updated successfully, but these errors were encountered: