Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly Data Model Release #539

Closed
3 of 4 tasks
github-actions bot opened this issue Nov 1, 2024 · 10 comments
Closed
3 of 4 tasks

Monthly Data Model Release #539

github-actions bot opened this issue Nov 1, 2024 · 10 comments
Assignees
Labels

Comments

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

Summary

This issue helps ensure that at least one data model release is created monthly.

Checklist

@anngvu
Copy link
Collaborator

anngvu commented Nov 19, 2024

@changtotheintothemoon Can you do the release for this month since Aditya did the last month's and just so everyone goes through the process at least once?

@anngvu anngvu moved this to Todo in NF-OSI Sprints Nov 19, 2024
@changtotheintothemoon
Copy link
Contributor

Review last schematic tests or test current state of data model on DCA staging
staging...main
@anngvu
Is this the right place to review the branch staging to compare wit hthe current state of the data?

@anngvu
Copy link
Collaborator

anngvu commented Nov 19, 2024

@changtotheintothemoon The intention of the first item is to "check that templates can be generated so users don't complain about broken templates". Sometimes we can make a change in the data model and the template can't be generated or looks strange because of a bug. The easiest way is to confirm that templates OK is to look at the ones generated by the tests in a recent PR, e.g. your PR was merged pretty recently and shows successful tests #543. Or the old way was to go to the staging instance of the DCA (https://dca-staging.app.sagebionetworks.org/) and try generating templates through the UI. Again, this was sometimes done in the old days. But the first way is easier and faster, the second way is much more extensive and painful, but that's an option if you also want to do "UI testing".

@anngvu
Copy link
Collaborator

anngvu commented Nov 19, 2024

@changtotheintothemoon Hmm, maybe we should have another issue to update the checklist to have more details... 🤔

@changtotheintothemoon
Copy link
Contributor

changtotheintothemoon commented Nov 20, 2024

@anngvu
#543 (comment)
It seems the manifest submission is failing since I added the ChIP-Seq template. Should we create an issue to fix this?

image

@anngvu
Copy link
Collaborator

anngvu commented Nov 20, 2024

@changtotheintothemoon Oh, don't worry about that -- that is not due to your changes (wouldn't have merged if it were). We just need to sign the new terms of use for the test account:
image

@anngvu
Copy link
Collaborator

anngvu commented Nov 20, 2024

But since you have reviewed and clarified the recent test results, go ahead and check off the first item!

@changtotheintothemoon
Copy link
Contributor

Check if any other updates should be put into this release so they don't have to wait until the next

#542

#553

Two more PR's under work. Should I wait until this merges with the staging branch?

@anngvu
Copy link
Collaborator

anngvu commented Nov 20, 2024

One is marked as draft, so I think you can ignore this one. I know the other is not urgent. In general, we can also ask at standup if any of the PRs are urgent and whether they can be merged quickly enough to get the release out. But I know these are not super important.

@anngvu anngvu moved this from Todo to In Progress in NF-OSI Sprints Nov 23, 2024
@changtotheintothemoon
Copy link
Contributor

Update DCA production config downstream (https://github.com/Sage-Bionetworks/data_curator_config/blob/prod/NF-OSI/dca_config.json) with the new tag.

New PR available for this to change version of the tag:
Sage-Bionetworks/data_curator_config#227

@anngvu anngvu closed this as completed Dec 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants