-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
For use with Bower, ie. via http://rails-assets.org/ which would eliminate the need of repos such as https://github.com/ecleel/jquery-oembed-rails.
Thanks for the PR @hakkiplaten. Sign the CLA above and we'll get this landed. |
All done. Thanks! |
"license": "MIT", | ||
"ignore": [ | ||
"**/.*", | ||
"node_modules", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a couple Updates
jquery
should be included as adependency
node_modules
,bower_components
andtest(s)
don't need to be ignored cause they don't exist in this module. You should instead ignoreexamples/
,*.md
, andCHANGELOG
.
Good catch! Changes committed. jQuery should already be included as a dependency, however I'm not sure about the version number. |
Had an invalid version number. Should be fixed now. |
Could we merge #41? Bower should automatically pick up on it and add it to its available versions, which in turn should fix Thank you! |
Turns out this field is now ignored by Bower: https://github.com/bower/spec/blob/master/json.md#version Courtesy of @hut8: @potench hence, would you mind merging the latest and renaming the git tag to a semver one instead (ie. |
@hakkiplaten let's remove the bower config. Not sure why anyone would use bower over npm at this point anyways. |
@potench this is discussed at length at tenex/rails-assets#291, but the common consensus seems to be that Bower and the Bower proxy Rails-Assets.org is currently the simplest way for Ruby on Rails developers to maintain their JS dependencies. JS front-end development is moving too fast, and current NPM solutions for Ruby on Rails are too complex. |
@hakkiplaten you can also fork this repository and push a tag if you want to make sure the steps are exactly right. Maintaining the bower.json file in this repo shouldn't be a big issue considering that the version doesn't need to be bumped. |
@hut8 that would have to be as a last resort.
Good point! |
@potench mind taking a last stab at this?
This way, Rails developers can use this repo directly and no longer have to be dependent on wrappers such as https://github.com/ecleel/jquery-oembed-rails whose last commit is from 2014. |
@potench any word here, friend? Over at https://github.com/tenex/rails-assets we're trying to push semantic version tags to help other tools (like Bower, which rails-assets uses) integrate with libraries like this one. I bet @hakkiplaten would help you out if you need it! |
For use with Bower.io, ie. via http://rails-assets.org/ which would eliminate the need of repos such as https://github.com/ecleel/jquery-oembed-rails.