Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column data type detection should be case insensitive #191

Open
ConPac opened this issue May 30, 2023 · 0 comments
Open

Column data type detection should be case insensitive #191

ConPac opened this issue May 30, 2023 · 0 comments

Comments

@ConPac
Copy link

ConPac commented May 30, 2023

Hi,

Column data type detection should be case insensitive, given that SQLite follows SQL standards where identifiers are case insensitive when not quoted, which is the case for column data type definition.

Using v4.2.4, a feature table defined as create table feature (id integer not null, geometry geometry, constraint primary key(id)) is not loaded and could emit this error messages:
Unsupported column data type integer
Unsupported column data type geometry

This kind of errors could be avoided modifying GeoPackageDataType.fromName function (and similar GeometryType.fromName function) like this:
function fromName(type) { return GeoPackageDataType[type.toUpperCase()]; }

Thanks in advance,
Paco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant