-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relations not returning error in MGCP translation when unable to translate #4970
Comments
Findings so far:
|
Since the translator isn't run when there are no tags to translate - I.e. only having the "type" tag - I think we could modify the core to add an error tag if the translator isn't run on a feature. I don't know what this would impact. I tried using an osm file with two multi polygons, one with a tag (
Trying the same file but changing
Getting curious, I created another OSM file that has:
Results:
Looking at this, it seems that tags on a relation stomp on tags on members. |
I would expect that if the tags of a relations could not be translated to an FCODE, the translation would return the tag
error=No Valid Feature Code
like it does for nodes and ways. Instead, is seems the OSM tags just pass through.I'll create a branch with a test that is failing in this scenario.
The text was updated successfully, but these errors were encountered: