Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for CRD CEL validation #2984

Open
bjee19 opened this issue Jan 7, 2025 · 0 comments
Open

Add tests for CRD CEL validation #2984

bjee19 opened this issue Jan 7, 2025 · 0 comments
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Milestone
v2.0.0

Comments

@bjee19
Copy link
Contributor

bjee19 commented Jan 7, 2025 •
edited by mpstefan
Loading

The gateway-api repository has tests for their CEL validation on CRDs found here: https://github.com/kubernetes-sigs/gateway-api/tree/main/pkg/test/cel.

Currently we manually test our CEL validation on CRDs, however it could be beneficial to follow the standard set in the gateway-api repository and create functional tests for them.

Acceptance

  • Verify that all CEL statements work as expected for the CRDs we own.
@bjee19 bjee19 added enhancement New feature or request tests Pull requests that update tests and removed enhancement New feature or request labels Jan 7, 2025
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Jan 7, 2025
@mpstefan mpstefan added this to the v2.0.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@mpstefan @bjee19