From 26b3301698f0af73eb5031a5f0e4554a3b9a1ce5 Mon Sep 17 00:00:00 2001
From: Arnout Engelen <arnout@bzzt.net>
Date: Sat, 23 Nov 2024 13:06:31 +0100
Subject: [PATCH] Tests: mail: smtp: assert whether backend authentication is
 expected

We expect that the SMTP proxy does not authenticate to the backend,
except in the `PROXY` case and in the case where `proxy_smtp_auth`
is enabled.

This makes tests fail when we violate that expectation.
---
 lib/Test/Nginx/SMTP.pm | 16 +++++++++++++++-
 mail_proxy_protocol.t  |  2 +-
 mail_proxy_smtp_auth.t |  2 +-
 3 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/lib/Test/Nginx/SMTP.pm b/lib/Test/Nginx/SMTP.pm
index f088f5fe..aaf84d81 100644
--- a/lib/Test/Nginx/SMTP.pm
+++ b/lib/Test/Nginx/SMTP.pm
@@ -150,8 +150,14 @@ sub socket {
 
 ###############################################################################
 
+sub fail {
+	my ($client, $reason) = @_;
+	print $client '500 failed: ' . $reason . CRLF;
+	$client->close();
+}
+
 sub smtp_test_daemon {
-	my ($port) = @_;
+	my ($port, $with_auth) = @_;
 	my $proxy_protocol;
 
 	my $server = IO::Socket::INET->new(
@@ -167,6 +173,7 @@ sub smtp_test_daemon {
 		print $client "220 fake esmtp server ready" . CRLF;
 
 		$proxy_protocol = '';
+		my $authenticated = 0;
 
 		while (<$client>) {
 			Test::Nginx::log_core('||', $_);
@@ -177,8 +184,15 @@ sub smtp_test_daemon {
 				print $client '250 hello ok' . CRLF;
 			} elsif (/^rset/i) {
 				print $client '250 rset ok' . CRLF;
+			} elsif (/^auth/i and not $with_auth) {
+				fail($client, "No authentication expected");
 			} elsif (/^auth plain/i) {
 				print $client '235 auth ok' . CRLF;
+				$authenticated = 1;
+			} elsif (/^mail/i and $with_auth and not $authenticated) {
+				fail($client, "Authentication expected");
+			} elsif (/^rcpt/i and $with_auth and not $authenticated) {
+				fail($client, "Authentication expected");
 			} elsif (/^mail from:[^@]+$/i) {
 				print $client '500 mail from error' . CRLF;
 			} elsif (/^mail from:/i) {
diff --git a/mail_proxy_protocol.t b/mail_proxy_protocol.t
index d4f4852d..3c318bc0 100644
--- a/mail_proxy_protocol.t
+++ b/mail_proxy_protocol.t
@@ -91,7 +91,7 @@ http {
 
 EOF
 
-$t->run_daemon(\&Test::Nginx::SMTP::smtp_test_daemon);
+$t->run_daemon(\&Test::Nginx::SMTP::smtp_test_daemon, port(8026), 1);
 $t->run()->plan(8);
 
 $t->waitforsocket('127.0.0.1:' . port(8026));
diff --git a/mail_proxy_smtp_auth.t b/mail_proxy_smtp_auth.t
index 4eb92b94..16040d90 100644
--- a/mail_proxy_smtp_auth.t
+++ b/mail_proxy_smtp_auth.t
@@ -75,7 +75,7 @@ http {
 
 EOF
 
-$t->run_daemon(\&Test::Nginx::SMTP::smtp_test_daemon);
+$t->run_daemon(\&Test::Nginx::SMTP::smtp_test_daemon, port(8026), 1);
 $t->run()->plan(7);
 
 $t->waitforsocket('127.0.0.1:' . port(8026));