Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-signed certs updates as old certs were expired #6524

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sdutta9
Copy link
Contributor

@sdutta9 sdutta9 commented Sep 26, 2024

Proposed changes

As part of this PR, I am updating the old self-signed certs with new ones that are valid for 5 years.

Related Bug: #6433

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sdutta9 sdutta9 requested a review from a team as a code owner September 26, 2024 21:08
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 26, 2024
@jjngx jjngx linked an issue Sep 27, 2024 that may be closed by this pull request
1 task
@jjngx jjngx added the chore Pull requests for routine tasks label Sep 27, 2024
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Oct 16, 2024
Copy link

github-actions bot commented Oct 30, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@danielnginx
Copy link
Collaborator

I have hereby read the F5 CLA and agree to its terms

@AlexFenlon
Copy link
Contributor

Hi @sdutta9,

We appreciate your work on this but we are going to do a different approach.

We will give you credit for your contribution on our release notes once that becomes available in v4.0.0.

I hope you are happy about this.

@sdutta9
Copy link
Contributor Author

sdutta9 commented Nov 7, 2024

Hi @sdutta9,

We appreciate your work on this but we are going to do a different approach.

We will give you credit for your contribution on our release notes once that becomes available in v4.0.0.

I hope you are happy about this.

Hi @AlexFenlon

I care the least about credits as long as the expired certificates are fixed. To me updating certificates is a simple task, and being part of F5 which is a security-first company, I don't feel comfortable sharing an example with expired certificates (even if they are self-signed and only used as a sample example) with customers. I will surely be happy the sooner you fix all expired certs in the main branch. 🙂

@vepatel vepatel added chore Pull requests for routine tasks and removed python Pull requests that update Python code tests Pull requests that update tests labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

[Bug]: Certs in example and test folders are expired
6 participants