Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set staticSSLPath to a variable for reuse #6872

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Nov 27, 2024

Proposed changes

set staticSSLPath to a variable for reuse later on as well as move up controller_namespace for later use

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner November 27, 2024 11:51
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.23%. Comparing base (729570c) to head (3d07222).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6872   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          88       88           
  Lines       20354    20357    +3     
=======================================
+ Hits        10835    10837    +2     
- Misses       9074     9075    +1     
  Partials      445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) November 27, 2024 15:45
@j1m-ryan j1m-ryan merged commit 7e7535d into main Nov 27, 2024
81 checks passed
@j1m-ryan j1m-ryan deleted the update-static-ssl-path branch November 27, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants