Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor lbc to add metadata struct #6885

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Add metadata struct to lbc, for the NIC pod and namespace. In the future this can be extended to add other metadata related to NIC.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner November 29, 2024 11:29
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 29, 2024
@j1m-ryan j1m-ryan changed the title refactor lbc namespace refactor lbc to add metadata struct Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (0bbf069) to head (5a2610b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 33.33% 2 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
internal/k8s/ingress_link.go 0.00% 1 Missing ⚠️
internal/k8s/leader.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6885      +/-   ##
==========================================
- Coverage   53.16%   53.15%   -0.01%     
==========================================
  Files          88       88              
  Lines       20394    20396       +2     
==========================================
  Hits        10842    10842              
- Misses       9109     9111       +2     
  Partials      443      443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan merged commit 726fe44 into main Nov 29, 2024
30 checks passed
@j1m-ryan j1m-ryan deleted the chore/refactor-lbc-namespace branch November 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants