Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick recent documentation changes #2815

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

This pull request cherry-picks changes from 3 recent documentation PRs from
main to the 1.5 release branch. More specifically, the work in the following PRs:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


mrajagopal and others added 3 commits November 25, 2024 11:40
Troubleshooting in Kubernetes requires collecting data from various sources of the kubernetes API.
The nginx-supportpkg-for-k8s is such a tool that NGINX has created to make this data collection as easy as possible.

This PR updates the support page of NGF docs referencing this tool in a similar manner to what was added to NIC docs
Added some more information to help ease the installation flow for both helm installation and creating the JWT and then installing.
@ADubhlaoich ADubhlaoich requested review from a team as code owners November 25, 2024 11:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2024
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) November 25, 2024 11:45
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (4c1f7d3) to head (11ec348).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #2815   +/-   ##
============================================
  Coverage        89.86%   89.86%           
============================================
  Files              107      107           
  Lines            10997    10997           
  Branches            50       50           
============================================
  Hits              9883     9883           
  Misses            1054     1054           
  Partials            60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ADubhlaoich ADubhlaoich merged commit 4ad7473 into nginxinc:release-1.5 Nov 25, 2024
42 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/pick-recent-fixes branch November 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants