Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run clippy in CI #46

Merged
merged 2 commits into from
Sep 1, 2023
Merged

ci: run clippy in CI #46

merged 2 commits into from
Sep 1, 2023

Conversation

ivanitskiy
Copy link
Contributor

@ivanitskiy ivanitskiy commented Aug 31, 2023 •
edited
Loading

Proposed changes

Run Clippy in CI and fix existing Clippy warnings.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@f5yacobucci
Copy link
Contributor

I think this should satisfy and close #32

@ivanitskiy ivanitskiy merged commit 2072f8a into nginxinc:master Sep 1, 2023
4 of 5 checks passed
@ivanitskiy ivanitskiy mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f5yacobucci f5yacobucci f5yacobucci approved these changes

@dekobon dekobon Awaiting requested review from dekobon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanitskiy @f5yacobucci