Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for java 9 modules #179

Open
ghost opened this issue Sep 30, 2020 · 2 comments
Open

add support for java 9 modules #179

ghost opened this issue Sep 30, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 30, 2020

adding Automatic-Module-Name header in the manifest.mf jar file is enough. You don't need to create a module-info.java class if you don't want to

@zapov
Copy link
Member

zapov commented Oct 1, 2020

Sure, we can add that. I'm not quite up-to-date with all this stuff... so it would be helpful if more info is provided.

What should be this name for java8 library? I'm assuming it can't be the same

@ghost
Copy link
Author

ghost commented Oct 2, 2020

thanks for taking into account my proposal.

It could be something like Automatic-Module-Name: com.dslplatform.json (just like packages, following a reverse DNS notation).

good article on this topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant