Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing in Revenj.AspNetCore #164

Open
Kobus-Smit opened this issue Sep 18, 2021 · 4 comments
Open

Tracing in Revenj.AspNetCore #164

Kobus-Smit opened this issue Sep 18, 2021 · 4 comments

Comments

@Kobus-Smit
Copy link
Contributor

Hi @zapov

How do I enable Performance.TraceDatabase with Revenj.AspNetCore?

<!--add key="Performance.TraceDatabase" value="true" /-->

Thanks

@zapov
Copy link
Member

zapov commented Sep 18, 2021

I did not port that project to .NET standard/core.
I'll look if its feasible to do so.

@zapov
Copy link
Member

zapov commented Oct 23, 2021

I've included it in new release, although you might need to reference some type explicitly to have it available on scanning

@Kobus-Smit
Copy link
Contributor Author

Kobus-Smit commented Oct 24, 2021

Thanks @zapov

I've set Revenj.Plugins.Aspects.PerformanceTrace.Configuration.TraceAll to true

I'm still struggling to get the logs in Serilog. It's is probably more a TraceSource .NET Core thing.

It looks like this is needed on all Revenj's TraceSources:

https://github.com/Kobus-Smit/revenj-examples/blob/bdeeb143acaea0d39c38c080fb75c11f63135406/DotNetCore/TracingTest/Program.cs#L23-L24

Any idea how to do this on all Revenj's TraceSources from within my app?

@zapov
Copy link
Member

zapov commented Oct 24, 2021

I've read the official stance and not sure I want to change anything ATM.

The best course of action for now seems to replicate the code with your own logging: https://github.com/ngs-doo/revenj/blob/master/csharp/Plugins/Revenj.Plugins.Aspects/DatabaseTrace/Configuration.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants