Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomainEventHandler failed resolution may display incorrect message #65

Open
nutrija opened this issue Nov 25, 2016 · 0 comments
Open

DomainEventHandler failed resolution may display incorrect message #65

nutrija opened this issue Nov 25, 2016 · 0 comments

Comments

@nutrija
Copy link
Contributor

nutrija commented Nov 25, 2016

When submitting an event, following error can display:
Can't find domain event store for Some.Event. Is Some.Event a domain event and does it have registered store

This message is incorrect when any of event handler's dependencies fail to instantiate. Further, the message can mask true error/exception message. For example:

public class SomeEventProcessor : IDomainEventHandler<Some.Event>
{
    public SomeEventProcessor(Mailer mailer) {
        ...

public class Mailer
{
    public Mailer() {
        throw new ConfigurationsErrorException("I'm missing some setting");

In this case, a "Can't find domain event..." message will be displayed, instead of Mailer's message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant