Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend #70

Open
aspitaleri opened this issue Oct 4, 2021 · 1 comment
Open

Amend #70

aspitaleri opened this issue Oct 4, 2021 · 1 comment

Comments

@aspitaleri
Copy link

Hi all,
the TBAmend step require a lot of time in case of several inputs. I am wondering whether there an option in TBAmend by which adding new samples in a previous run would increase the speed without redoing the TBAmed for all samples, including the previous one. So basically, MTBSeq could just compare the new samples with the previous fasta to calculate the new matrix. I know that MTBseq pipeline require some restraints to make the TBAmend but in first approximation using the previous matrix could help in terms of speed. What do you think? Does it need some perl-hacking?
Best

@TaKohl
Copy link
Contributor

TaKohl commented Oct 4, 2021

Hello Andrea, really good point with TBAmend, and an interesting idea to shave off calculation time by using the previous calculation as a basis. Problem is, I imagine this to be quite problematic to implement as a generic solution. Having a recalculated joint analysis with just new samples added is a very specific case. We are currently looking into options on how to improve a joint analysis in general, e.g. by splitting up the calculation into several parallel processes or switching to consensus. However, if you can implement a solution along the lines you described, that would be interesting to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants