Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercom API should take a method name and an object, not array. #86

Closed
jonathan3692bf opened this issue Mar 4, 2020 · 2 comments
Closed

Comments

@jonathan3692bf
Copy link

In src/intercomAPI.ts on branch 2.0, args should be an object, not an array.

Just change line 1 from:

export default function(method: string, ...args: Array<any>) {

to:

export default function(method: string, args: any) {
@ChristianJacobsen
Copy link

Not sure if this is what is being proposed fixed in #77? I think it is.

@jonathan3692bf
Copy link
Author

True, though #77 lumps method and args together. Either way, we achieve the same goal, so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants