Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be more palettes? #3

Open
tomjemmett opened this issue Mar 12, 2019 · 3 comments
Open

Should there be more palettes? #3

tomjemmett opened this issue Mar 12, 2019 · 3 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@tomjemmett
Copy link
Member

Currently we have one palette that uses a handful of the colours from the Identity (Blue, Green, Red, Purple, Orange), and then the levels as defined by the Identity (Blues, Neutrals, Support Greens, Highlights).
Should we create some more named palettes? Perhaps a RAG palette? Are the existing palettes suitable, or could they be improved?

@tomjemmett tomjemmett self-assigned this Mar 12, 2019
@tomjemmett tomjemmett added this to the v 0.1.0 milestone Mar 12, 2019
@tomjemmett tomjemmett added the question Further information is requested label Mar 12, 2019
@ghost
Copy link

ghost commented May 20, 2021

Hi,

Appreciate I am late to the party but this is something I have been looking at recently.

If we refer to the colour palettes in the NHS Identity it seems like the ones in this package do not align properly:

image

Would we be better defining our colour palettes as above ^ instead of the of the colour sections (e.g. Level 1: NHS blues, Level 2: NHS neutrals, etc):

  • core blues: c(DarkBlue = "#003087", BrightBlue = "#0072CE", LightBlue = "#41B6E6", AquaBlue = "#00A9CE")
  • pale neutrals: c(MidGrey = "#768692", PaleGrey = "#E8EDEE")
  • greens: c(DarkGreen = "#006747", Green = "#009639", LightGreen = "#78BE20", AquaGreen = "#00A499")
  • black: c(Black = "#231F20")
  • dark grey: c(DarkGrey = "#425563")
  • highlights: c(Purple = "#330072", DarkPink = "#7C2855", Pink = "#AE2573", DarkRed = "#8A1538", Red = "#DA291C", Orange = "#ED8B00", WarmYellow = "#FFB81C", Yellow = "#FAE100")

Then this would enable you to recreate all of the colour palettes in the identity (core blues + pale neutrals, greens + black + dark grey, highlights) and also custom palettes by combining in a different way.

The default could then be core blues + pale neutrals

@ghost
Copy link

ghost commented May 20, 2021

Additionally, I am looking to add some functionality like https://github.com/bbc/bbplot/blob/master/R/bbc_style.R into this package if there is appetite?

@tomjemmett
Copy link
Member Author

I think you are probably right - these are much nicer descriptions! If you want to create a PR I will approve and merge :-) Might be worth having both set's of names unless that would cause confusion...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant