diff --git a/CHANGELOG.md b/CHANGELOG.md index 890e0cab3..a70b61f8b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # NHS.UK frontend Changelog +## 8.0.2 - 019 October 2023 + +:wrench: **Fixes** + +- Resolves the bug of the drop down menu covering the main content of the page ([PR 898](https://github.com/nhsuk/nhsuk-frontend/pull/898)). + ## 8.0.1 - 02 October 2023 :wrench: **Fixes** diff --git a/app/components/header/header-service-name-with-nav.njk b/app/components/header/header-service-name-with-nav.njk index 538a72508..d4680c3e6 100644 --- a/app/components/header/header-service-name-with-nav.njk +++ b/app/components/header/header-service-name-with-nav.njk @@ -28,10 +28,6 @@ 'url' : '#', 'label' : 'Accessibility' }, - { - 'url' : '#', - 'label' : 'Design principles' - }, { 'url' : '#', 'label' : 'Community and contribution' diff --git a/package-lock.json b/package-lock.json index cb00d502e..eaae0ef9d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "nhsuk-frontend", - "version": "8.0.0", + "version": "8.0.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "nhsuk-frontend", - "version": "8.0.0", + "version": "8.0.2", "license": "MIT", "devDependencies": { "@babel/core": "^7.18.6", diff --git a/package.json b/package.json index 6a3b5e20e..e48a569ee 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nhsuk-frontend", - "version": "8.0.1", + "version": "8.0.2", "description": "NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.", "scripts": { "prepare": "gulp bundle", diff --git a/packages/components/header/header.js b/packages/components/header/header.js index 11aa6c184..a4520c9aa 100644 --- a/packages/components/header/header.js +++ b/packages/components/header/header.js @@ -109,9 +109,9 @@ class Header { */ openMobileMenu() { - const marginBody = this.mobileMenu.offsetHeight this.menuIsOpen = true this.mobileMenu.classList.remove('nhsuk-header__drop-down--hidden') + const marginBody = this.mobileMenu.offsetHeight this.navigation.style.marginBottom = `${marginBody}px` this.mobileMenuToggleButton.setAttribute('aria-expanded', 'true') diff --git a/packages/components/header/template.njk b/packages/components/header/template.njk index ff7efbeb0..0e5ae9a20 100644 --- a/packages/components/header/template.njk +++ b/packages/components/header/template.njk @@ -104,6 +104,7 @@ + {% endif -%} {% if showSearch == "true" and showNav == "false" %} @@ -132,32 +133,34 @@ {% if showNav == "true" and params.primaryLinks and showSearch == "false" %} {# close nhsuk-header__container #} - - + +
+ +
{% endif -%} diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Header_with_a_service_name_search_and_navigation_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Header_with_a_service_name_search_and_navigation_0_document_3_Surface_iPad_Pro.png index be876c3c6..9d51b9024 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Header_with_a_service_name_search_and_navigation_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Header_with_a_service_name_search_and_navigation_0_document_3_Surface_iPad_Pro.png differ