From 712e9d9208d914c4ca7cbdce0d14719ca4659062 Mon Sep 17 00:00:00 2001 From: Adam Fenwick Date: Tue, 5 Dec 2023 09:33:11 +0000 Subject: [PATCH 1/2] Updating secondary and reverse button to use correct variable rather than darken --- CHANGELOG.md | 1 + packages/components/button/_button.scss | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 62c590f9e..3299bfaef 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Updated header component unit tests ([PR 900](https://github.com/nhsuk/nhsuk-frontend/pull/900)). - Fixed bug where the header didn't align with the main width container ([PR 902](https://github.com/nhsuk/nhsuk-frontend/pull/902)). This fixes [Issue 901](https://github.com/nhsuk/nhsuk-frontend/issues/901) +- Updating secondary and reverse buttosn to use their hover variable rather than darken ## 8.0.2 - 19 October 2023 diff --git a/packages/components/button/_button.scss b/packages/components/button/_button.scss index be8945b03..2b998b29c 100644 --- a/packages/components/button/_button.scss +++ b/packages/components/button/_button.scss @@ -117,7 +117,7 @@ $button-shadow-size: 4px; box-shadow: 0 $button-shadow-size 0 $nhsuk-secondary-button-shadow-color; &:hover { - background-color: darken($nhsuk-secondary-button-color, 10%); + background-color: $nhsuk-secondary-button-hover-color; } &:focus { @@ -145,7 +145,7 @@ $button-shadow-size: 4px; color: $nhsuk-reverse-button-text-color; &:hover { - background-color: darken($nhsuk-reverse-button-color, 5%); + background-color: $nhsuk-reverse-button-hover-color; color: $nhsuk-reverse-button-text-color; } From b4c07feba059cbb2946d13264611d0ec186e7891 Mon Sep 17 00:00:00 2001 From: Adam Fenwick Date: Tue, 5 Dec 2023 10:00:58 +0000 Subject: [PATCH 2/2] Update CHANGELOG.md Co-authored-by: Andy Mantell <134642+andymantell@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3299bfaef..8e21727f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ - Updated header component unit tests ([PR 900](https://github.com/nhsuk/nhsuk-frontend/pull/900)). - Fixed bug where the header didn't align with the main width container ([PR 902](https://github.com/nhsuk/nhsuk-frontend/pull/902)). This fixes [Issue 901](https://github.com/nhsuk/nhsuk-frontend/issues/901) -- Updating secondary and reverse buttosn to use their hover variable rather than darken +- Updating secondary and reverse buttons to use their hover variable rather than darkening the base colour ## 8.0.2 - 19 October 2023