Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control C on the kit brings up a gulp warning #390

Open
vickytnz opened this issue Nov 8, 2024 · 1 comment
Open

Control C on the kit brings up a gulp warning #390

vickytnz opened this issue Nov 8, 2024 · 1 comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) JavaScript Pull requests that update Javascript code

Comments

@vickytnz
Copy link
Contributor

vickytnz commented Nov 8, 2024

Bug Report

Usually the kit is shut down with Control C in the terminal or similar.

However this brings up a warning

The following tasks did not complete: default, watch
Did you forget to signal async completion?

At the least this is unnerving, and at worse could mean that the kit is using up CPU when it shouldn't.

If there is a better way to turn off the prototype kit it would be good to document this, or alternatively that this can be fixed to not be a problem.

@frankieroberto
Copy link
Contributor

I had a brief look into this but couldn’t figure it out quickly. I think it’s something to do with asynchronous tasks.

Control-C is the right command to run and everything does shut down (so no impact on CPU) but the message is displayed fractionally before the processes all shut down. Confusing!

Will try and fix but might have to ask someone who knows a bit more about Gulp!

@frankieroberto frankieroberto added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Nov 9, 2024
@vickytnz vickytnz added the JavaScript Pull requests that update Javascript code label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) JavaScript Pull requests that update Javascript code
Development

No branches or pull requests

2 participants