Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait On Occurrence Wrapper.vi should be re-entrant. Currently causes hang in our app #354

Closed
NIbbuchanan opened this issue Mar 19, 2024 · 3 comments

Comments

@NIbbuchanan
Copy link
Contributor

NIbbuchanan commented Mar 19, 2024

vi.lib\gRPC\LabVIEW gRPC Library\Shared\Wait On Occurrence Wrapper.vi has a few issues:

  • It is not marked as re-entrant/in place so if a grpc call takes awhile, it blocks other calls from going through.
  • The separate compiled code flag is not checked, which is annoying when going between different contexts (ie. windows an RT) and this VI has to be saved each time. Use the same settings as the Wait on Occurence.vi it calls.

Our app (FlexLogger) was hanging because of this and when I changed this VI to be re-entrant/in-place, it worked again.

@NIbbuchanan NIbbuchanan changed the title Wait On Occurrence Wrapper.vi doesn't have the right VI properties set to be re-entrant Wait On Occurrence Wrapper.vi isn't re-entrant Mar 19, 2024
@NIbbuchanan NIbbuchanan changed the title Wait On Occurrence Wrapper.vi isn't re-entrant Wait On Occurrence Wrapper.vi should be re-entrant Mar 19, 2024
@NIbbuchanan NIbbuchanan changed the title Wait On Occurrence Wrapper.vi should be re-entrant Wait On Occurrence Wrapper.vi should be re-entrant. Currently causes hang in our app Mar 19, 2024
@yash-ni yash-ni closed this as completed Mar 28, 2024
@NIbbuchanan
Copy link
Contributor Author

@yash-ni - Thanks for fixing this! Any idea when there will be an export available with this fix? Thanks!

@yash-ni
Copy link
Collaborator

yash-ni commented Apr 3, 2024

Hi @NIbbuchanan, sorry for the late reply. We will be releasing the export next week.

@ni-sujain
Copy link
Collaborator

@NIbbuchanan the export is now available here https://github.com/ni/grpc-labview/releases/tag/v1.2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants