Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline React SVG Needs Update #54

Closed
mandyMooreFan opened this issue Oct 13, 2019 · 2 comments
Closed

Inline React SVG Needs Update #54

mandyMooreFan opened this issue Oct 13, 2019 · 2 comments

Comments

@mandyMooreFan
Copy link
Contributor

High Code Injection

Package js-yaml

Patched in >=3.13.1

Dependency of babel-plugin-inline-react-svg

Path babel-plugin-inline-react-svg > svgo > js-yaml

More info https://npmjs.com/advisories/813

@mandyMooreFan
Copy link
Contributor Author

airbnb/babel-plugin-inline-react-svg#64

Currently listed as false positive in npm audit. Bable requires this process to be synchronous and the reason they aren't updating.

The reason this is not considered a security risk is highlighted here:
airbnb/babel-plugin-inline-react-svg#59

@mandyMooreFan
Copy link
Contributor Author

If the js-yaml package is getting shipped in the production build you can look at things like:
https://github.com/bhovhannes/svg-url-loader

I assume at some point they will get tired of getting issues related to that and just either kill the dep or find a way to bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant