Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16 in SineSubtract.cxx might need to be removed #5

Open
MyoungchulK opened this issue May 18, 2022 · 1 comment
Open

16 in SineSubtract.cxx might need to be removed #5

MyoungchulK opened this issue May 18, 2022 · 1 comment

Comments

@MyoungchulK
Copy link
Contributor

MyoungchulK commented May 18, 2022 •
edited
Loading

16 is altering the magnitude of power_spectra values.
And SineSubtract.cxx is using the same power_spectra as an initial guess of fit.
Since several Set~LimitedVariable functions (line 787 ~ 803) in the dofit are using amp (power_spectra) values on the first attempt of Minimize(), It might give wrong minimization results to users
Hope This makes sense!
@cozzyd
Copy link
Collaborator

cozzyd commented May 18, 2022

Yes, this appears to be vestigial somehow. Can you check if removing it doesn't somehow blow things up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cozzyd @MyoungchulK