Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data loading typo #27

Open
quantumiracle opened this issue Apr 17, 2024 · 1 comment
Open

data loading typo #27

quantumiracle opened this issue Apr 17, 2024 · 1 comment

Comments

@quantumiracle
Copy link

quantumiracle commented Apr 17, 2024

Hi, this line should be:

assert self.buffer.num_eps == (self.buffer.capacity // _cfg.episode_length), \
	f'Buffer has {self.buffer.num_eps} episodes, expected {self.buffer.capacity // _cfg.episode_length} episodes.'
@nicklashansen
Copy link
Owner

Great catch! This seems to be a leftover from the previous buffer implementation (pre commit 54145a4). I'll fix this soon and double-check that everything else in the offline trainer works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants