Add needed volume fields in deployment and bump chart version

nicklausbrown · Sep 7, 2023 · 42ab885 · 42ab885
1 parent 6f1c4f4
commit 42ab885
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 32 deletions.
diff --git a/charts/jupyter/Chart.yaml b/charts/jupyter/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.0
+version: 0.3.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/jupyter/templates/deployment.yaml b/charts/jupyter/templates/deployment.yaml
@@ -29,47 +29,44 @@ spec:
       containers:
         - name: {{ .Chart.Name }}
           securityContext:
-            {{- toYaml .Values.securityContext | nindent 12 }}
+                  {{- toYaml .Values.securityContext | nindent 12 }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           ports:
-            - name: jupyter
-              containerPort: 8888
+            - name: http
+              containerPort: 8000
               protocol: TCP
           livenessProbe:
             httpGet:
-              path: /api/status
-              port: jupyter
+              path: /
+              port: http
           readinessProbe:
             httpGet:
-              path: /api/status
-              port: jupyter
+              path: /
+              port: http
           resources:
-            {{- toYaml .Values.resources | nindent 12 }}
+                  {{- toYaml .Values.resources | nindent 12 }}
+                {{- with .Values.envVariables }}
           env:
-            - name: JUPYTER_ENABLE_LAB
-              value: "yes"
-            {{- if .Values.extraEnv }}
-            {{- toYaml .Values.extraEnv | nindent 12 }}
-            {{- end }}
-          {{- if .Values.command.enabled }}
-          command: {{ .Values.command.value }}
-          args: {{ .Values.command.args }}
+                  {{- toYaml . | nindent 12 }}
+                {{- end }}
+                {{- with .Values.volumeMounts }}
+          volumeMounts:
+                  {{- toYaml . | nindent 12 }}
+                {{- end }}
+            {{- with .Values.volumes }}
+      volumes:
+            {{- toYaml . | nindent 8 }}
           {{- end }}
-          {{- if .Values.rootUser }}
-          securityContext:
-            allowPrivilegeEscalation: false
-            runAsUser: 0
-          {{- end }}
-      {{- with .Values.nodeSelector }}
+          {{- with .Values.nodeSelector }}
       nodeSelector:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
-      {{- with .Values.affinity }}
+            {{- toYaml . | nindent 8 }}
+          {{- end }}
+          {{- with .Values.affinity }}
       affinity:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
-      {{- with .Values.tolerations }}
+            {{- toYaml . | nindent 8 }}
+          {{- end }}
+          {{- with .Values.tolerations }}
       tolerations:
-        {{- toYaml . | nindent 8 }}
-      {{- end }}
+            {{- toYaml . | nindent 8 }}
+          {{- end }}
diff --git a/charts/jupyter/values.yaml b/charts/jupyter/values.yaml
@@ -84,4 +84,10 @@ affinity: {}
 
 runtimeClassName: "nvidia"
 
-rootUser: true
+rootUser: true
+
+volumes: []
+
+volumeMounts: []
+
+envVariables: []