Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

fix: set path to fieldName for resolver(#19) #20

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hennessyevan
Copy link

@hennessyevan hennessyevan commented Oct 23, 2019

Fixes #19
Fixes #21

When no root path is specified, registry should pick up the top-level fieldName from info to infer the path of the resolver.

I added a test for this and it also works against my rather large mongoose+graphql backend with E2E tests.

Looking forward to getting this merged 👍 lmk if there's anything missing. Btw, I appreciate the api design and cleanliness of this repo. Big ups

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #20 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   98.96%   98.97%   +0.01%     
==========================================
  Files          12       12              
  Lines         290      293       +3     
  Branches       74       82       +8     
==========================================
+ Hits          287      290       +3     
  Misses          2        2              
  Partials        1        1
Impacted Files Coverage Δ
src/registry.ts 96.77% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3629a...8682d71. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant