Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form repository into library + executable #39

Open
eyalroz opened this issue Sep 10, 2024 · 2 comments
Open

Form repository into library + executable #39

eyalroz opened this issue Sep 10, 2024 · 2 comments

Comments

@eyalroz
Copy link

eyalroz commented Sep 10, 2024

c++filt is great, but - it is also useful to be able to demangle in code. Since the functionality is already here, why not rearrange this project so that one of the targets is a (C++ I guess) library for demangling, and the executable uses it?

@nico
Copy link
Owner

nico commented Nov 3, 2024

That's already kinda the setup -- the main binary is all of 187 lines. What concretely would you change?

@eyalroz
Copy link
Author

eyalroz commented Nov 3, 2024

I would:

  1. Add a(n aptly-named) library target in the CMakeLists.txt
  2. Have the executable target depend on the library target
  3. (Add cmake --install support for the library ; this takes some CMake voodoo)
  4. Potentially, streamline the interface between the executable and the library so that the latter is easy to use and difficult to abuse)
  5. Specify and document the library's API clearly, e.g. in the README.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants