Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining classes #16

Open
Sudomeapizza opened this issue Nov 1, 2017 · 4 comments
Open

Combining classes #16

Sudomeapizza opened this issue Nov 1, 2017 · 4 comments

Comments

@Sudomeapizza
Copy link

It would be cool to have an option to have all of your free periods merge with other periods. Like how if you had a free 4th, it would merge with lunch and it would be called "free".
screen shot 2017-11-01 at 1 20 45 pm

@nicolaschan
Copy link
Owner

When two "free" periods merge, which name should take precedence? When you combine Free with Lunch, which name should the merged period take on?

If you call it Free, could this ever cause confusion with some students thinking Lunch is missing? If you call it Lunch, could this cause confusion about when Lunch starts for other students? The case where I think the distinction is relevant is if you have something like a club meeting at Lunch and want to know when it will start.

What are your thoughts on this?

@Sudomeapizza
Copy link
Author

Maybe it can be Free the whole way, but then when there is for example 5 or 10 mins left the circle is not going to reset.
if I have a free session for 1 hour, then lunch for 30 minutes
The circle would be 90 minutes long. The first 55 (or 50 depending on settings) minutes would be the free period and the <5-10 (or however long)> min before would trigger the yellow bg, then 50% of that time would trigger orange. Then when the 30 mins of lunch starts, the circle is 1/3rd of the way there and is now back to green with the main "period" being 'Reminder: Lunch' in gray text to not stand out but be there as a reminder.

Let me know if you need more clarification.

@nicolaschan
Copy link
Owner

Sorry for the delay; I've been working on other issues/features before this one.

In your example, what do you suggest the time displays during the 1 hour free session? Would it count down from 1 hour 30 min (to the end of Lunch) or 1 hour (to the beginning of lunch)? Either way, I'm worried this mixture between colors and circle proportion not corresponding as normal might be confusing.

@Sudomeapizza
Copy link
Author

I would say to go through lunch, because that is technically free time. And would prefer that. (It could also be a subsetting if you want to have breaks like brunch/lunch be included or separate from free time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants