Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Instanceof failing hasn't been pushed to npm + temporary workaround #7

Open
alecmolloy opened this issue Feb 9, 2019 · 3 comments

Comments

@alecmolloy
Copy link

Hey, thanks for the work on this great package! And thanks for merging the fix for Instanceof in #5. It would be great if you could publish this fix to NPM, but I wanted to leave this issue here for anyone who needs to use it, and isn't aware you can get around using npm by just referring to this repo as such in your package.json:

"three-orbitcontrols-ts": "git+https://[email protected]/nicolaspanel/three-orbitcontrols-ts.git"
@MichalHe
Copy link
Contributor

Probably a more long term solution would be to update readme.md to contain a passage with the instructions above for everyone to see. I will create a PR containing the changes in the near future.

@MichalHe
Copy link
Contributor

Created #8 which contains the instructions. Thank you @alecmolloy for pointing this out.

@Chrisbright10
Copy link

please merge the PR for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants