Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently armed sensors #1022

Open
apocaliss92 opened this issue Aug 31, 2024 · 9 comments
Open

Currently armed sensors #1022

apocaliss92 opened this issue Aug 31, 2024 · 9 comments

Comments

@apocaliss92
Copy link

Would it be possible to include in the alarmo entity attributes the sensors currently harmed? Basically the on configured for the current active mode
I would need this to filter out some notifications from an external security system

@masi
Copy link

masi commented Aug 31, 2024

You mean armed?

Anyway, I'd appreciate attributes that list alls sensors, sensors for each mode and sensors for the active mode (reqeuest of @apocaliss92 ).

My use-case is that I specifically want to check the availability of the security devices. My work-around is to duplicate the sensor list. But this is error-prone when I add or replace a device.

@apocaliss92
Copy link
Author

Yes sorry, armed, bad English :)

@apocaliss92
Copy link
Author

I could implement this already on my local folder, not a complicated exercise, I will try to open a pr during next week

@apocaliss92 apocaliss92 changed the title Currently harmed sensors Currently armed sensors Aug 31, 2024
Copy link

github-actions bot commented Oct 1, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 1, 2024
@apocaliss92
Copy link
Author

@nielsfaber I have some changes prepared to propose in a PR, is it possible to have permissions or should I just fork the project?

@github-actions github-actions bot removed the Stale label Oct 9, 2024
@apocaliss92
Copy link
Author

nevermind, got it working

@nielsfaber
Copy link
Owner

I agree it can be useful that users have access to the list of sensors configured in alarmo.
However, I don't agree that this should be added as an attribute, since this can be a lot of information and it would become a long and unreadable list.
I think we should look for another way to share the information, for example via a service or event.
Also, we should discuss what information is shared, since as @masi already points out, some users may want to access the full sensor list rather than only the currently armed sensors, so I would prefer to implement a generic approach that cover multiple use-cases.

@apocaliss92
Copy link
Author

This was the easiest for me with my limited py skills
I believe a proper sensor for each of the "combinations" would be the best. Since mqtt is very easy to extend, what about having 1 for each of the lists under the same topic?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants