Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in AWS when generating signed urls #15

Open
sciabarracom opened this issue Jul 26, 2021 · 2 comments
Open

Errors in AWS when generating signed urls #15

sciabarracom opened this issue Jul 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@sciabarracom
Copy link
Contributor

If you try to generate a signed url you get an error message
@sciabarracom sciabarracom added the bug Something isn't working label Jul 26, 2021
@sciabarracom sciabarracom mentioned this issue Jul 26, 2021
Closed
@jthomas
Copy link
Contributor

jthomas commented Jul 26, 2021

Can you provide the error output? We have an integration test for this - which passed last time I checked. Can you run them and confirm it fails? I'm interested to think about why that code is now failing before we merge the fix.

jthomas added a commit to jthomas/nimbella-sdk-python that referenced this issue Jul 30, 2021
@jthomas
Fixing nimbella#15
cfe20e8 
Ensure endpoint parameter is passed to S3 client in files.
This is necessary for use with regional buckets.

Added unit and integration tests to check this feature for PUT requests.
@jthomas jthomas mentioned this issue Jul 30, 2021
Merged
@jthomas
Copy link
Contributor

jthomas commented Jul 30, 2021

After a lot of investigation - I tracked this down to an undocumented feature of the S3 boto library with regional endpoints for new regions....

I've also added unit and integration tests to verify that we can do both GET & PUT requests using the storage libraries with signed URLs.
https://github.com/nimbella/nimbella-sdk-python/pull/18/files

I've got a few other PRs to merge and then we can release a new version.

jthomas added a commit that referenced this issue Jul 30, 2021
@jthomas
Supporting regional buckets for S3 (#18)
d2213d3 
Fixing #15

Ensure endpoint parameter is passed to S3 client in files.
This is necessary for use with regional buckets.

Added unit and integration tests to check this feature for PUT requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jthomas @sciabarracom