Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Danger for Dart to automate pull request reviewing & code coverage reporting #242

Open
luongvo opened this issue Jul 21, 2023 · 0 comments · May be fixed by #282
Open

Integrate Danger for Dart to automate pull request reviewing & code coverage reporting #242

luongvo opened this issue Jul 21, 2023 · 0 comments · May be fixed by #282
Assignees
@doannimble
Labels
type : feature
Milestone
1.14.0

Comments

@luongvo
Copy link
Member

luongvo commented Jul 21, 2023 •
edited
Loading

Why

Inspired by what we applied in our several templates to use Danger as a tool to automate the PR reviewing and code coverage reporting directly on each PR, we should apply Danger for Dart to our Flutter Templates.

  • Ensure to have Danger integrated for both the root template & template project.

Ref: https://blog.appsynth.net/stop-saying-you-forgot-to-in-code-review-danger-dart-edition-8c61e402cd4e

Who Benefits?

Developers
@luongvo luongvo added this to the 1.11.0 milestone Jul 21, 2023
@luongvo luongvo modified the milestones: 1.11.0, 1.12.0 Sep 6, 2023
@luongvo luongvo modified the milestones: 1.12.0, 1.13.0 Oct 31, 2023
doannimble added a commit that referenced this issue Nov 13, 2023
@doannimble
[#242] Add danger
48c8616
@doannimble doannimble linked a pull request Nov 13, 2023 that will close this issue
Draft
doannimble added a commit that referenced this issue Nov 13, 2023
@doannimble
[#242] Install danger js
9160333
doannimble added a commit that referenced this issue Nov 13, 2023
@doannimble
[#242] Use dart pub
5000893
doannimble added a commit that referenced this issue Nov 13, 2023
@doannimble
[#242] Add sample danger file
4febe35
doannimble added a commit that referenced this issue Nov 21, 2023
@doannimble
[#242] Add lint into dangerfile
f88a03c
@luongvo luongvo modified the milestones: 1.13.0, 1.14.0 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doannimble doannimble

Labels
type : feature
Projects
None yet
Milestone
1.14.0
2 participants
@luongvo @doannimble