Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply string casing to method params while deriving proxies and services #30

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Apply string casing to method params while deriving proxies and services

633794f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Apply string casing to method params while deriving proxies and services #30

Apply string casing to method params while deriving proxies and services
633794f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy Report succeeded Dec 16, 2024 in 0s

Clippy Report

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 349 in core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> core/src/lib.rs:346:33
    |
346 |               Value::Number(n) => n
    |  _________________________________^
347 | |                 .as_u64()
348 | |                 .map(SubscriptionId::Number)
349 | |                 .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
    | |______________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
    |
349 |                 .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
    |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 113 in client/src/wasm_websocket.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> client/src/wasm_websocket.rs:113:24
    |
113 |         let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as `RefCell<Option<Sender<()>>>` is not `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `RefCell<Option<Sender<()>>>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 349 in core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> core/src/lib.rs:346:33
    |
346 |               Value::Number(n) => n
    |  _________________________________^
347 | |                 .as_u64()
348 | |                 .map(SubscriptionId::Number)
349 | |                 .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
    | |______________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
    |
349 |                 .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
    |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 349 in core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
   --> core/src/lib.rs:346:33
    |
346 |               Value::Number(n) => n
    |  _________________________________^
347 | |                 .as_u64()
348 | |                 .map(SubscriptionId::Number)
349 | |                 .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
    | |______________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
    |
349 |                 .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
    |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~