Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatal : Aucun nom trouvé, impossible de décrire quoi que ce soit. #85

Open
n-rodriguez opened this issue Oct 22, 2024 · 2 comments
Open

fatal : Aucun nom trouvé, impossible de décrire quoi que ce soit. #85

n-rodriguez opened this issue Oct 22, 2024 · 2 comments

Comments

@n-rodriguez
Copy link
Contributor

n-rodriguez commented Oct 22, 2024 •
edited
Loading

I got this error message every time I run a bundle rspec command (or whatever command)

This comes from this commit f5c97a8#r148222395 which is considered as a bad practice.

IMHO f5c97a8#r148222395 should be reverted.

Thank you!
@thde
Copy link
Member

thde commented Oct 23, 2024

I don't understand. Why should it be bad practice?

@n-rodriguez
Copy link
Contributor Author

I don't understand. Why should it be bad practice?

Because depending on the platform git is not always available.

It's commonly admitted to use git to list gem files, but more and more Rubyist tend to change this to use pure Ruby to avoid relying on git presence. For example : https://github.com/fxn/zeitwerk/blob/main/zeitwerk.gemspec#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thde @n-rodriguez