Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings and New Chat buttons are missing accessibility labels in the Mio version #279

Open
MarcoZehe opened this issue Mar 20, 2021 · 3 comments
Assignees
Labels
swiftui-bug General weirdness presumably caused by SwiftUI

Comments

@MarcoZehe
Copy link

I'm blind and use VoiceOver, and found that the two buttons in the toolbar on top of the Mio window are missing accessibility labels. The counterparts on iPhone are fine in the current Nio TestFlight build.

@helje5 helje5 added the bug Something isn't working label Mar 20, 2021
@helje5 helje5 self-assigned this Mar 20, 2021
@helje5
Copy link
Contributor

helje5 commented Mar 20, 2021

That actually looks like a macOS SwiftUI bug. I was already using a proper Label element as the Button content, but even attaching an explicit accessibility(label:) doesn't make a label show up in the accessibility inspector. Nor does using the exact same setup on iOS (which doesn't use Label, but Image w/ .accessibility(label:)) change anything.

I moved the preferences to a window on macOS, which makes more sense anyways.

@helje5 helje5 added swiftui-bug General weirdness presumably caused by SwiftUI and removed bug Something isn't working labels Mar 20, 2021
@kloenk
Copy link
Member

kloenk commented Aug 5, 2021

Is this resolved with the removing of the catalyst version? IIRC Mio did replace the catalyst?

@helje5 helje5 changed the title Settings and New Chat buttons are missing accessibility labels in the Mio Catalyst version Settings and New Chat buttons are missing accessibility labels in the Mio version Aug 5, 2021
@helje5
Copy link
Contributor

helje5 commented Aug 5, 2021

The title was just wrong, Mio was never Catalyst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swiftui-bug General weirdness presumably caused by SwiftUI
Projects
None yet
Development

No branches or pull requests

3 participants