Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable emoji #16

Open
Hipska opened this issue Sep 24, 2018 · 4 comments
Open

Add option to disable emoji #16

Hipska opened this issue Sep 24, 2018 · 4 comments

Comments

@Hipska
Copy link
Contributor

Hipska commented Sep 24, 2018

It would be nice to have an option to specify if you don't want/need the Emoji in the messages. Since the new format (coloured line) they seem redundant, because notification type is also printed.

@Hipska
Copy link
Contributor Author

Hipska commented Oct 1, 2018

Do you agree with this? If yes, I would try to implement it with a PR.

Maybe remove the part where there is a default emoji set if none applicable for that state?

@nisabek
Copy link
Owner

nisabek commented Oct 8, 2018

Hi Hipska,

By Emoji you mean the icon showed in front of the message?
It looks like there are quite a number of requests that wish to have the message "rendered" in a specific way. I'm a bit worried about the state of the code already - it feels too many "if/else" statements.
It would be very helpful if you could come up with some "renderers" instead of the logic just written in the command - so there would be I imagine an IconRenderer and a ServiceMessageRenderer and HostMessageRenderer and a HostDetailedMessageRenderer that includes more information about the host e.g. IP address.

What do you think?

Thanks!
Nune

@Hipska
Copy link
Contributor Author

Hipska commented Oct 8, 2018

Yes, the icon in front, they are emoji.

How would such a renderer look like? A separate function for each?

@nisabek
Copy link
Owner

nisabek commented Oct 8, 2018

yes, that's what I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants