Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default provider set to dev not local #239

Open
medgar-nitric opened this issue Nov 12, 2021 · 0 comments
Open

Default provider set to dev not local #239

medgar-nitric opened this issue Nov 12, 2021 · 0 comments

Comments

@medgar-nitric
Copy link
Contributor

When performing a custom container dockerbuild, the CLI was specifying the PROVIDER=dev:

docker build starter -f docker/list.dockerfile -t starter-list-dev --progress plain --build-arg PROVIDER=dev

However, the docker hub image for this is:

https://hub.docker.com/r/nitricimages/membrane-local

The nitric docker images include a 'local' build for local development, however, the CLI code uses 'dev' to refer to this entity:

  • packages/base/src/commands/build.ts
  • packages/common/src/task/create-build-tasks.ts
  • packages/common/src/types/providers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant