Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Split package" (JPMS) issue #1035

Closed
alexei-osipov opened this issue Sep 5, 2024 · 1 comment · Fixed by #1036
Closed

"Split package" (JPMS) issue #1035

alexei-osipov opened this issue Sep 5, 2024 · 1 comment · Fixed by #1036
Assignees
Labels
Milestone

Comments

@alexei-osipov
Copy link

Currently Nitrite is released as multiple JARs with different parts of functionality (that's good).

However these JARs have overlapping package names for some classes causing "split package" problem and triggering errors if Java Platform Module System (JPMS) is used in the app that depends on Nitrite main JAR and nitrite-jackson-mapper JAR.

For instance, there are classes for package org.dizitart.no2.common.mapper in both org.dizitart:nitrite and org.dizitart:nitrite-jackson-mapper JARs.

As result, when JPMS is enabled, app gets errors like this:

error: the unnamed module reads package org.dizitart.no2.common.mapper from both org.dizitart.no2.jackson and org.dizitart.no2

Possible solution: move classes of nitrite-jackson-mapper from package org.dizitart.no2.common.mapper to a dedicated non-overlapping package like org.dizitart.no2.common.mapper.jackson.

@anidotnet
Copy link
Contributor

Thanks for reporting the issue. I need to take a look at this and push the fix in next release.

@anidotnet anidotnet self-assigned this Sep 6, 2024
@anidotnet anidotnet added the bug label Sep 6, 2024
anidotnet added a commit that referenced this issue Sep 6, 2024
@anidotnet anidotnet linked a pull request Sep 6, 2024 that will close this issue
@anidotnet anidotnet added this to the 4.3.1 milestone Sep 6, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Nitrite 4.x Development Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants