Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not symlink modules with overlapping paths #97

Open
jgresty opened this issue Sep 21, 2022 · 0 comments
Open

Does not symlink modules with overlapping paths #97

jgresty opened this issue Sep 21, 2022 · 0 comments

Comments

@jgresty
Copy link

jgresty commented Sep 21, 2022

Suppose a go.mod contains:

require (
    repo/foo v1.0.0
    repo/foo/bar v1.0.0
)

then go mod will store the directory structure:

go
└── pkg
    └── mod
        └── repo
            ├── foo
            │   └── bar
            └── [email protected]

so that repo/foo v1.0.0 is installed under go/pkg/mod/repo/[email protected] to avoid conflicts.

However when gomod2nix creates the vendor-env derivation it seems to be only linking the longest path, in this case repo/foo/bar.

Discovered with go.opentelemetry.io/otel and related packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant