Add some driver version-selection logic #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulucs I ended up finding another source for drivers, not sure if that solves the instigating problem, see nixGL/known_drivers/mk-nvidia-drivers.py Line 24 in 3ee94e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170, which stemmed from Nvidia not hosting every single minor driver version.
This PR adds a somewhat smart driver version selection logic (first one released after the device's driver) to keep the nix and device drivers as close as possible while trying to download an existing one.
Currently the list is hard-coded, collected with the following script:
copy($$('a').map(e=>e.innerText).filter(e=>e.match(/[0-9]/)).map(e=>e.substring(0, e.length-1)).map(s=>`"${s}"`).join("\n"))from https://download.nvidia.com/XFree86/Linux-x86_64If/when #131 gets merged, the driver selection logic can be modified to select from existing drivers