Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Build v1.0.6 #147

Open
herter4171 opened this issue Mar 30, 2021 · 3 comments
Open

Can't Build v1.0.6 #147

herter4171 opened this issue Mar 30, 2021 · 3 comments

Comments

@herter4171
Copy link

I've been trying to build v1.0.6, because some tooling I was given used that version. All I've done to build is

git clone --branch v1.0.6 https://github.com/njoy/NJOY21.git
cd NJOY21
git submodule update --init
mkdir build && cd build
cmake ..

I did see on the v1.0.6 readme that a signature file could be generated, but I don't have the means to generate that file without that version of the binary. I can't make sense of the CMake errors, but something isn't right here. CMake logs can be viewed here.

How can I get this built?

@herter4171
Copy link
Author

Well, I got a signature file from someone upstream. The script fetch_subprojects.py seems to ignore the njoy21 commit spec, because it just checks out the head of master. To get around that, I run

sed -i '90,91d' metaconfigure/fetch_subprojects.py

Removing those lines allows the build to proceed with the desired tag checkout.

I still think there's a broader issue here regarding the ease of building old tags, because I shouldn't have to modify Python scripts to make it work. Also, downloading an archive for a tag doesn't yield anything buildable, because git is so embedded in the build system.

@whaeck
Copy link
Member

whaeck commented Mar 30, 2021

I was already looking into your issue, and experiencign the same issues as you. We've actually completely overhauled the build system some time ago and removed all of the subprojects and metaconfigure business. More recent versions of NJOY21 use this new system and it builds a lot cleaner.

We are actually planning on generating off-line installation packages as well (which we can implement with the newer build system).

Is there a particular reason why you need to stick to this version of NJOY21?

@herter4171
Copy link
Author

@whaeck, I had a feeling, and thanks for looking into this. I was handed some tooling to generate nuclear data libraries that isn't exactly verbose about NJOY21 errors, and I haven't got it to cooperate on v1.2.2 or v1.1.0. The docs I have say they used v1.0.6, so I'm checking to see if that's a hard requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants