Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to pass tests on newly cloned fork #656

Open
itsjayway opened this issue Jun 17, 2023 · 3 comments
Open

Unable to pass tests on newly cloned fork #656

itsjayway opened this issue Jun 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@itsjayway
Copy link
Contributor

itsjayway commented Jun 17, 2023

Describe the bug
yarn jest does not pass on master branch when newly cloned

To Reproduce
Steps to reproduce the behavior:

  1. Fork
  2. git clone [email protected]:jibranabsarulislam/igbo_api.git igbo_api_test
  3. cd igbo_api_test
  4. yarn install
  5. yarn build
  6. firebase content:
    a. console.firebase.google.com -> Create a project
    b. project name: igboapitest
    project id (is also): igbopitest
    c. no analytics -> Create project
    d. change .firebaserc default and staging to igboapitest
    e. "Get started by adding Firebase to your app" -> Web
    f. app nickname: igbotestapp
    g. copy config into src/services/firebase.js (into both staging and prod config)
    h. firebase login
    i. firebase use default
  7. yarn dev # navigating to http://127.0.0.1:8080/ renders page
  8. ctrl+C to stop development server
  9. yarn start:database # terminal 1
  10. yarn jest # terminal 2
    a. Database is connected
    b. Seeding database...
    c. tests start, and fails 3 suites/56 tests

Expected behavior
Codebase on master branch should pass established tests

Desktop (please complete the following information):

  • OS: Ubuntu 20.04 and Windows 10
  • Browser Brave (N/A?)
  • Version Version 1.46.140 Chromium: 108.0.5359.99 (Official Build) (64-bit)

Smartphone (please complete the following information):
N/A

Screenshots (if applicable)
#653 (comment)
image

image

@ijemmao
Copy link
Collaborator

ijemmao commented Jun 21, 2023

@jibranabsarulislam can you copy and paste the entire error message when you get a chance?

@itsjayway
Copy link
Contributor Author

@ijemmao
Copy link
Collaborator

ijemmao commented Jun 22, 2023

thanks for the link, i'll take a look thru the logs @jibranabsarulislam

i merged a fix so that future PRs will be able to have their tests run automatically within our CI so you don't need to run tests on your local machine in the future - however, this doesn't fix the root issue that's happening since we encourage writing new tests for new features, I'll keep this issue open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants