Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to configure custom HMR port #394

Open
peterhirn opened this issue Oct 6, 2024 · 1 comment · May be fixed by #404
Open

[Feature] Add option to configure custom HMR port #394

peterhirn opened this issue Oct 6, 2024 · 1 comment · May be fixed by #404

Comments

@peterhirn
Copy link

Currently the HMR port is always random, see https://github.com/nksaraf/vinxi/blob/main/packages/vinxi/lib/dev-server.js#L52

For a working HMR setup in GitHub Codespaces we need to be able to configure a fixed port.

server: {
  hmr: {
    protocol: 'wss',
    port: 1234,
    clientPort: 443
  }
}

References

schiller-manuel added a commit to schiller-manuel/vinxi that referenced this issue Oct 26, 2024
@schiller-manuel schiller-manuel linked a pull request Oct 26, 2024 that will close this issue
@matt-potter
Copy link

Got he same issue here with a docker / local kubernetes development workflow - we aren't able to dynamically open ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants