-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bart-large-mnli multi_class does not agree with Python version #101
Comments
I didn't read this issue properly and might have opened a duplicate - #103 . Have you found any further information regarding this since you've opened the issue? |
Hello both of you @jimidle and @abishekmuthian. I apologize for taking so long to respond! I somehow missed the GitHub notifications, and @marco-nicola was sure I had already dealt with your request. In fact, this is not a desired behavior. Here we probably have either a bug or a serious loss of accuracy during the various steps of the forward. Need to investigate, probably comparing the intermediate values of the python implementation. Would any of you be able to assist? |
Thanks for getting back @matteo-grella , GitHub seems to remove notifications from the site if it sends the email and your emails might not be reaching your inbox. It does indeed seem to be a serious bug. I can test the project if there's any new patches, But I'm afraid I cannot aid in active debugging immediately due to time constraint. |
Hey @abishekmuthian, It was a simple True flag that was supposed to be a False flag that confused us both! Hence, with spaGO, output is forced to be a distribution (sum must be 1), whereas with Python, the output is free. Let me know Matteo |
I see, Glad that the issue was simple to identify and fix. I will conduct some more tests this weekend and get back. |
Got back to testing Spago. If I understand your last comment correctly, multiClass flag in Spago is !multi_label flag of Python i.e. It needs to be false to enable it. Making it false does distribute the confidence values to ~1 but still doesn't match the python #103. Model: spago/valhalla/distilbart-mnli-12-3 Text: "PalmOS on Raspberry Pi" Spago multiClass:false
Spago multiClass:true
Python multi_label:true
|
If you convert
facebook/bart-large-mnli
and use it to evaluate the demo text at huggingface and compare against a local Python setup for verification, we find that:Python code is
Go code, with same text and classes, is:
Similarly using the model
valhalla/distilbart-mnli-12-3
also gives wildly different results to the online huggingface demo, using the same text and label set as above.So, is there something else I need to do, or is the zsc code not working? My go code is essentially just like the zsc demo code.
The text was updated successfully, but these errors were encountered: