Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show how a tool dependency is used. #186

Open
tschaffter opened this issue Feb 15, 2022 · 1 comment
Open

Show how a tool dependency is used. #186

tschaffter opened this issue Feb 15, 2022 · 1 comment
Assignees
Labels
Enhancement New feature or request

Comments

@tschaffter
Copy link
Member

The information page of the app shows the individual tools used by the PHI Deidentifier (e.g. person name annotator, date annotator). The table shows the type of the tool, e.g. nlpsandbox:date-annotator. When we created the web app, tools were doing a single operation like date annotation. Since then, the NLP Sandbox added the tool type nlpsandbox:phi-annotator, which implements several operations. The issue is that when using nlpsandbox:phi-annotator tools as dependency, the table no longer provide information on which operation we use them for.

image

A solution would be to add an extra column that shows the type of operation the tool is used for. This is not the same thing as the existing column "Type", which provides the NLP Sandbox tool type, which may implement multiple operation. So we could have:

  • Type => Tool Type
    • => Operation Type
@tschaffter tschaffter added the Enhancement New feature or request label Feb 15, 2022
@boyleconnor
Copy link
Collaborator

We decided:

Turn the ToolDependencies object (from an array of Tool objects) into an array of objects called ToolDependencys. These objects each have two members: a functionalType (e.g. nlpsandbox:date-annotator) and tool (a Tool).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants