-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linter #56
Add Linter #56
Conversation
Bumps @material-ui/data-grid from 4.0.0-alpha.20 to 4.0.0-alpha.21. Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/create-react-app/commits/[email protected]/packages/react-scripts) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 12.7.1 to 12.8.0. - [Release notes](https://github.com/testing-library/user-event/releases) - [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md) - [Commits](testing-library/user-event@v12.7.1...v12.8.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.5 to 4.2.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.1.5...v4.2.2) Signed-off-by: dependabot[bot] <[email protected]>
Update Fork
Bumps node from 15.9.0-alpine3.12 to 15.11.0-alpine3.12. Signed-off-by: dependabot[bot] <[email protected]>
…nt/main/typescript-4.2.2 Bump typescript from 4.1.5 to 4.2.2 in /client
…nt/main/testing-library/user-event-12.8.0 Bump @testing-library/user-event from 12.7.1 to 12.8.0 in /client
…nt/main/material-ui/data-grid-4.0.0-alpha.21 Bump @material-ui/data-grid from 4.0.0-alpha.20 to 4.0.0-alpha.21 in /client
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 12.7.1 to 12.8.1. - [Release notes](https://github.com/testing-library/user-event/releases) - [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md) - [Commits](testing-library/user-event@v12.7.1...v12.8.1) Signed-off-by: dependabot[bot] <[email protected]>
…library/user-event-12.8.1
…ent/main/testing-library/user-event-12.8.1 Bump @testing-library/user-event from 12.7.1 to 12.8.1 in /client
…n/node-15.11.0-alpine3.12 Bump node from 15.9.0-alpine3.12 to 15.11.0-alpine3.12 in /client
…nt/main/react-scripts-4.0.3 Bump react-scripts from 4.0.2 to 4.0.3 in /client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good! There's only one suggestion, after which you could merge this PR (use the option "squeeze and merge" to keep the commit history clean).
run: npm ci | ||
- name: Run ESLint | ||
working-directory: ${{env.working-directory}} | ||
run: npx eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding the script npm run lint
to package.json to make it easy to developer to lint the project. The CI/CD workflow should then rely on the command npm run lint
(requires to install dev npm dependencies with npm install --only=dev
).
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add ESLint Linter to Phi-Deidentifier-App