Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linter #56

Closed
wants to merge 40 commits into from
Closed

Add Linter #56

wants to merge 40 commits into from

Conversation

boyleconnor
Copy link
Collaborator

Add ESLint Linter to Phi-Deidentifier-App

dependabot bot and others added 30 commits March 1, 2021 06:10
Bumps @material-ui/data-grid from 4.0.0-alpha.20 to 4.0.0-alpha.21.

Signed-off-by: dependabot[bot] <[email protected]>
Bumps node from 15.9.0-alpine3.12 to 15.11.0-alpine3.12.

Signed-off-by: dependabot[bot] <[email protected]>
…nt/main/typescript-4.2.2

Bump typescript from 4.1.5 to 4.2.2 in /client
…nt/main/testing-library/user-event-12.8.0

Bump @testing-library/user-event from 12.7.1 to 12.8.0 in /client
…nt/main/material-ui/data-grid-4.0.0-alpha.21

Bump @material-ui/data-grid from 4.0.0-alpha.20 to 4.0.0-alpha.21 in /client
…ent/main/testing-library/user-event-12.8.1

Bump @testing-library/user-event from 12.7.1 to 12.8.1 in /client
…n/node-15.11.0-alpine3.12

Bump node from 15.9.0-alpine3.12 to 15.11.0-alpine3.12 in /client
…nt/main/react-scripts-4.0.3

Bump react-scripts from 4.0.2 to 4.0.3 in /client
@boyleconnor boyleconnor requested a review from tschaffter April 13, 2021 16:07
@boyleconnor boyleconnor linked an issue Apr 13, 2021 that may be closed by this pull request
@boyleconnor boyleconnor self-assigned this Apr 13, 2021
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good! There's only one suggestion, after which you could merge this PR (use the option "squeeze and merge" to keep the commit history clean).

run: npm ci
- name: Run ESLint
working-directory: ${{env.working-directory}}
run: npx eslint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the script npm run lint to package.json to make it easy to developer to lint the project. The CI/CD workflow should then rely on the command npm run lint (requires to install dev npm dependencies with npm install --only=dev).

@boyleconnor boyleconnor mentioned this pull request Apr 27, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Up / Refactor React Client
2 participants