Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the new schema (incremental_load) #69

Open
mmaiers-nmdp opened this issue Oct 12, 2022 · 1 comment
Open

Consider changing the new schema (incremental_load) #69

mmaiers-nmdp opened this issue Oct 12, 2022 · 1 comment
Assignees

Comments

@mmaiers-nmdp
Copy link
Contributor

In the new schema
image
there are HAS_IPD_ALLELE edges from both GFE to IPD_Allele and IPD_Accession to IPD_Allele

The first issue is that both edges should be vectors (currently the one from IPD_Accession to IPD_Allele is scalar.

But there is a more fundamental issue which is that this model will not capture situations where the sequence changes but the IPD_Accession and the IPD_Allele stay the same. These are exactly the type of inconsistencies that this graph database is well suited to discover and catalog. With that in mind I propose that we update the schema to have IPD_Accession have an edge directly to the GFE. Or rather a "HAS_IPD_ACCESSION" edge from the GFE to the IPD_Accession node which will be symmetrical to the "HAS_IPD_ALLELE" from the GFE node to the IPD_Allele node.

This new HAS_IPD_ACCESSION should have an array of versions as an attribute.

Also the minor version should be included (e.g. HLA00012.1 not HLA00012) as the full accession number with attributes of the major potion "HLA00012" to allow queries that join these to not have to parse the name in cypher to get only the part left of the ".".

image

@mmaiers-nmdp
Copy link
Contributor Author

3016411 ID   HLA00789; SV 7; standard; DNA; HUM; 13220 BP.
3016412 XX
3016413 AC   HLA00789;
3016414 XX
3016415 SV   HLA00789.7
3016416 XX

Sub-version is in SV element and in the ID element

@pbashyal-nmdp pbashyal-nmdp self-assigned this Nov 14, 2022
@pbashyal-nmdp pbashyal-nmdp added this to the Complete Model milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants