Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support mentions of users with spaces in username #55

Open
nminchow opened this issue Dec 9, 2021 · 0 comments
Open

support mentions of users with spaces in username #55

nminchow opened this issue Dec 9, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nminchow
Copy link
Owner

nminchow commented Dec 9, 2021

The support added in #30 does handle quite a few use cases, but mentioning a user with a space in their username still requires you use the ID. We could probably fix this by checking usernames against the following words as well (I don't think the logic as written does this).
@nminchow nminchow added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nminchow