Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Disable nnfw by default @open sesame 09/21 13:35 #398

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

gichan-jang
Copy link
Member

Disable nnfw by default

  • To avoid armcl dependency problem on arm arch.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 19, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #398. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 19, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/398-202309191732380.37164402008057-80f62746c1d37cf0ca0d9f8d6c67a44bbfb38c20/.

Copy link
Member

@wooksong wooksong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api requires libnnstreamer-edge.so.0.2.4 but PPA provides libnnstreamer-edge.so.0.2.5 after nnstreamer/nnstreamer-edge@9f898eb.

FYI,

$ sudo ldconfig -p | grep edge
        libnnstreamer-edge.so.0.2.5 (libc6,x86-64) => /lib/x86_64-linux-gnu/libnnstreamer-edge.so.0.2.5
        libnnstreamer-edge.so (libc6,x86-64) => /lib/x86_64-linux-gnu/libnnstreamer-edge.so

$ apt policy nnstreamer-edge
nnstreamer-edge:
  Installed: 0.2.5.0-0~202309190236~ubuntu20.04.1
  Candidate: 0.2.5.0-0~202309190236~ubuntu20.04.1
  Version table:
 *** 0.2.5.0-0~202309190236~ubuntu20.04.1 500
        500 http://ppa.launchpad.net/nnstreamer/ppa/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status

@gichan-jang gichan-jang changed the title [Tizen] Disable nnfw by default [Tizen] Disable nnfw by default @open sesame 09/21 09:58 Sep 21, 2023
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 21, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/398-202309210958450.46248602867126-80f62746c1d37cf0ca0d9f8d6c67a44bbfb38c20/.

@gichan-jang gichan-jang changed the title [Tizen] Disable nnfw by default @open sesame 09/21 09:58 [Tizen] Disable nnfw by default @open sesame 09/21 13:35 Sep 21, 2023
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@@ -12,7 +12,7 @@
%define tensorflow_lite_support 1
%define tensorflow2_lite_support 1
%define tensorflow2_gpu_delegate_support 1
%define nnfw_support 1
%define nnfw_support 0
Copy link
Member

@myungjoo myungjoo Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid error simply by removing this?

BuildRequires: libarmcl
BuildConflicts: libarmcl-release

Copy link
Member Author

@gichan-jang gichan-jang Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Updated.
I checked that OneRT removed armcl backend onTizen.

Remove armcl dependency when nnfw is enabled.

Signed-off-by: gichan2-jang <[email protected]>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung jaeyun-jung merged commit 032b4d6 into nnstreamer:main Sep 27, 2023
2 checks passed
@gichan-jang gichan-jang deleted the disable/nnfw branch February 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants